Document: draft-ietf-spirits-protocol-07.txt
Reviewer: John Loughney
Date: March 17, 2004

I have been unable to fully review this document.  Part of the problem may
be due to the draft itself - having the flu hasn't helped.  I cannot say this
document is ready for publication, mostly because of my confusion when
reading the document.  I don't feel that the document is clearly written.
However, I think this work would have little impact directly upon the
health of the Internet, so it might be reasonable not to be overly
strict in a review.

Some background - I spent the early part of the 90's implementing IN
in PSTN switches, so I have a basic familiarity with the subject area.
I sat in several SPIRITS meetings, but decided that this wasn't entirely
productive use of my time.

Some comments, in an a somewhat random order.  Please note that I have
not had a chance to go through in great detail the main body of the
text - I am still having a hard time getting around all of the details
contained.

1) Formmating is off.

2) First usage of SPIRITS in the abstract should be expanded.

3) First major confusion, the abstract says:
	
   ".... Internet Call Waiting, Internet
   Caller-ID Delivery, are examples of SPIRITS services; as are
   location-based services on the cellular network.  The protocol is to
   define the building blocks from which many other services can be
   built."

   But the document seems to define 2 SIP event packages and an XML
   based schema for some services.  The document defines call related 
   events and gives examples, but this doesn't really seem like a 
   protocol to me. 

4) nit: 

   "... The term Public
   Switched Telephone Network (PSTN) is used here to include all manner
   of access; i.e. wireline circuit-switched network as well as the
   wireless circuit-switched network."

   "All manner of access"? Does this include IP? Avian carriers?

5) nit:

   ".... In general terms, an Internet host will express an interest in
   getting notifications of certain events occurring in the PSTN."

   How does an Internet host express interest?  Buying the PSTN a drink?

6) First full paragraph on page 6 brings up a lot of terminology like  
   "SPIRITS client", "SPIRITS server" - a terminology section would be nice.

7) Page 39 - changes section should be removed upon publication as an RFC.

8) Acronym section on page 39 should be moved up-front.

9) Normative references section should probably contain some references
   to the basic call state model in the PSDN.  A reference to a book writen 
   by one of the draft's co-authors seems a bit dodgy.  Rather should reference
   ITU-T or ANSI specs on IN.

   [2] Faynberg, I., L. Gabuzda, M. Kaplan, and N.Shah, "The Intelligent
   Network Standards: Their Application to Services", McGraw-Hill, 1997.

10) Needs IPR text.