Draft:  draft-ietf-smime-gost-06.txt
Reviewer: Black_David@emc.com
Review Date:  Friday 1/6/2006 7:27 PM CST
LC Date: 1/4/2006 

Summary: This draft is basically ready for publication, but has nits that
should be fixed before publication.

Review:
-------

(1) Sections 3.1 and 3.2 use symbolic OIDs (OBJECT IDENTIFIERs)
that are defined in the [CPALGS] reference.  If the symbolic
OIDs remain, then text should be added to each section to say that
the symbolic OID is defined in [CPALGS].  Alternatively, each OID
could be fully defined as is done in other sections.

(2) Section 7.1  Parameter micalg

   When using the algorithms defined in this document, micalg parameter
   SHOULD be set to "gostr3411-94" or it MAY be set to "unknown".

The "SHOULD do <x> or MAY do <y>" construction is problematic, as
it is not clear whether the "MAY" is implicitly a "SHOULD NOT".
Changing the "or" to "otherwise" would clarify this, and I suggest
that the "MAY" also be changed to a "MUST", so that the text reads:

   When using the algorithms defined in this document, micalg parameter
   SHOULD be set to "gostr3411-94" otherwise it MUST be set to "unknown".

If the "MUST" is not correct, the other possible values for micalg
should be listed.

(3) Section 8

   Cryptographic algorithm parameters affect rigidity of algorithms.

I don't understand "rigidity".  Was "strength" intended?

(4) The Authors' Addresses section (should be s' not 's) contains
contact info for a number of contributors who are not authors.  This
is ok, but the section might be better titled "Contact Information"
- see http://www.rfc-editor.org/policy.html#policy.auth2 .

Note to authors: Please obtain your Area Director (Russ)'s approval
before making any changes to this draft.