Draft:  draft-ietf-pwe3-ethernet-encap-10.txt
Reviewer: Joel M. Halpern [joel@stevecrocker.com]
Review Date: Monday 8/15/2005 11:18 AM CST
Telechat Date: Thursday 8/18/2005

Summary: This document appears ready for publication as a proposed standard.  There are some minor matters that can probably be dealt
with during whatever next revision is done.

Review:
-------
Probably minor:
Section 3.3 sometimes refers to the information it is discussing as the 
VLAN tab and sometimes as the VLAN ID.  I think these are supposed to be 
the same thing?  If they are actually two different concepts, then some 
technical text is required to avoid confusing the reader.  If they are the 
same thing, then a sentence reminding the reader of the meaning would be 
helpful.  (I suspect that VLAN ID refers to a field used to carry the VLAN 
tag, and that all will be clear later.  But it should be clear here.)
Also, the wording in this section makes it appear that this document is 
defining the 06 code point for the sub-TLV.  If so, shouldn't that appear 
in the IANA considerations section?

Section 3.4.3 on Frame Ordering says that if ordering is used, and 
misordered frames "will be dropped by the receiving PW".  However, in 
section 3.7.2 it says that Packets which are received out of order "MAY be 
dropped or reordered".  I think that this is just a matter of fixing the 
words in 3.4.3.  But they ought to be consistent.

Minor:
In the introduction, it says:
    ... this document assumes that a Pseudowire (PW) has been
    set up by using the LDP protocol as described in [PWE3-CTRL]. This
    may be via manual configuration, or a signaling protocol such as LDP
The sentence therefore says it is set up via LDP, and then says either 
manually or via LDP?  Presumably it
should say just the second phrase.

In figure 3 there is a pair of boxes labelled PW termination with a pointer 
labelled B.  The text following the diagram refers to the PW as terminating 
at point A in the diagram.  It appears that was supposed to say B.
This occurs again when it says "The point to the left of A, ... and any 
adaptation (NXP) functions ..." Since point A points
at the NSP, presumably that was supposed to say "to the left of B".
And the text reading "PW Termination", between A and B presumably needs to 
read "at B", since B points at the PW Termination box.

Section 3.3 "Ethernet Specific Interface Parameter Sub-TLV" really ought to 
explicitly state what protocol and message this sub-TLV is part of.  The 
reader can guess that it is some LDP message, but guessing is a bad practice.