Document: draft-ietf-ipsec-ike-ecc-groups-10.txt Reviewer: Joel M. Halpern [joel@stevecrocker.com] Review Date: Friday 10/20/2006 10:09 AM CST IETF LC Date: 11 November 2006 Summary: This document is nearly ready for publication as an Informational RFC. There are some minor items that should be resolved (or at least considered) before approval. Firstly, IDNits reports a large number if minor issues. The use of normative language does usually require referencing RfC 2119 for example. Secondly, the IANA considerations wording "It is propose that the id column be defined..." is odd. The document should simply say "This document assigns the IDs in table 2, and they should be entered in the registry foo (whatever registry keeps those identifiers.) [If there is not a registry, then that needs to be fixed.] Thirdly, and possibly ignorable, the text on keys (in the later part of the base section 2) refers to G without explanation. I can infer that this is the same as the value described (but not named G) in the elliptical curve section of RFC 2409. But a few words describing G here would probably be better. (It is unfortunate but probably unavoidable that none of the documents describing the representation of KE are RFCs. That should not hinder this publication.)