Document: draft-ietf-bmwg-hash-stuffing-07.txt
Reviewer: Joel M. Halpern [joel@stevecrocker.com]
Review Date: Friday 12/8/2006 9:37 AM CST
IESG telechat Date: December 14th, 2006

Summary: This document is almost ready for publication as an Informational 
RFC.  There is one item that should be fixed before publications, and 
several items that should be changed given that a respin is needed anyway.

Comments:

Moderate:
1)  In the MPLS recommendation, it is recommended that labels be 
uniformly distributed between 0 and 2^20.  Given that the labels 
0-15  are reserved for special function, and often have special 
processing or discarding, it strikes me that test equipment may well 
get unexpected results if it randomly attempts to use those for 
normal operations.  I would recommend checking the the MPLS standards 
as to the current reserved range, and making sure the random 
assignment stays out of that.

Minor:
         IDNits alerted the fact that the IPv4 address used as 
samples in Appendix C are not RFC 3330 documentation values 
(192.0.2.0/24).  Similarly, the IPv6 example does not use the IPv6 
documentation block assigned by RFC 3849 (2001:DB8::/32)
         In section 4.2, in describing how to create the MAC address, 
the upper byte is anded with 0xFC to clear the global/local and 
unicast/multicast bit so that the address will be a global 
multicast.  there are two minor issues here:
     Using a global MAC address construct from a random number and a 
port number is probably appropriate, but violates the standard.  It 
would probably be a good idea to acknowledge this fact, and explain 
why global (rather than local) addresses need to be used.
     The text refers to the two bits that are being controlled as the 
"high order two bits of taht byte."  While those are the first two 
bits that will be clocked out over the ethernet, they are not the 
"high order" bits in most peoples understanding of the term.