Draft: draft-pullen-srmp-06.txt Reviewer: elwynd@dial.pipex.com Review Date: Thursday 7/7/2005 2:14 AM CST Telechat Date: 7/7/2005 Summary: This document is close to being ready as an Experimental protocol specification. Review Comments: ---------------- There are a couple of points which deserve some attention before it is published in my opinion: - Wrap around and comparison of timestamps - 16 bit timestamps with millisecond resoution are proposed but there is no discussion of wrap around. This is a fairly standard problem but a quick comment would help. - The trade-off between bit saving in the headers and complexity may have come down too heavily on the side of bit saving. Consequently a number of different floating point formats packed into 16 bits are specified, which may result in significant implementation complexity... but its an experimental protocol, so maybe that is one of the things to sort out during experimentation. From the point of view of 'potential damage to the Internet', I am not familiar with the details of the Widmer/Handley multicast congestion control work which is being implemented in a modified form here, but I assume that this work islikely to be of good quality which is being properly discussed in an IETF WG. So even though this is a modified form it should not cause significant rampant congestion, and good experience will be obtained. The document also has a considerable number of nits - due to lack of time I haven't had chance to put these into a coherent form. I'll sort them out and mail them directly to the authors shortly. (apologies for the last minute delivery)